hexagon logo
Register Sign in
  • Replies 13 replies
  • Subscribers 30 subscribers
  • Views 414 views
  • Users 0 members are here
Options
Related

Ballooning script / Problem with "SetLine"

Lorenzo_be
Hi everyone,

I wanted to write a script, that loops through all comments in PCDMIS and changes them accordingly...

We use Ballooned drawings and sometimes have 5 times the same dimension so we'd name them (for example dimension number 80) (80.1) / (80.2) / (80.3) ...
The script should correct multiple occurences automatically. So I would just have to put (80) each time in my comment and the script will keep track of every occurence and change them...

Allmost everything works fine; Unluckily i still have problems with the "SetLine" Command... Says "missing Argument(s)" but in the documentation i dont see any clue on what's going wrong. 

Sub Main()
Dim PCDApp As Object
Dim PCDPartPrograms As Object
Dim PCDPartProgram As Object
Dim PCDCommands As Object
Dim PCDCommand As Object
Dim PCDComment As Object

Dim sContents As String
Dim iCnt As Integer
Dim j As Integer
Dim iCount As Integer
Dim num as Integer
Dim arr() as Integer


Set PCDApp = CreateObject("PCDLRN.Application")
Set PCDPartPrograms = PCDApp.PartPrograms
Set PCDPartProgram = PCDApp.ActivePartProgram
Set PCDCommands = PCDPartProgram.Commands

For iCnt = 1 To PCDCommands.Count
Set PCDCommand = PCDCommands.Item(iCnt)
If (PCDCommand.IsComment) Then
Set PCDComment = PCDCommand.CommentCommand
If (PCDComment.CommentType = 1) And (inStr(1,PCDComment.Comment,"Aln")<1)Then
For j = 1 To 10
If (PCDComment.GetLine(j)="") Then Exit For
sContents = PCDComment.GetLine(j)
MsgBox sContents 'Bulle mit Klammern
sContents = Replace(sContents, "(", "")
sContents = Replace(sContents, ")", "")
MsgBox sContents 'Bulle ohne Klammern
If IsNumeric(sContents) Then
num = sContents
ReDim Preserve arr(num)
arr(num) = arr(num) + 1
sContents = "(" & num & "." & arr(num) & ")"
MsgBox sContents 'Angepasste Bulle mit Klammern
PCDComment.SetLine(j,sContents) 'funktioniert nicht...
End If
Next
End If
End If
Next iCnt
End Sub
​

Any Ideas?
Parents
  • good Day,

    the pcDMIS basic.dll / compiler is a bit wonky.
    I 've had bad experiences with arrays, and I would recommend that you avoid them altogether in pcDMIS scripts
    auto convert combined with arrays rarely works, prefer to use Cint Cstr etc

    well,

    a bit exaggerated but here a string is used as an array substitute: 
      Dim PCDApp As Object
  Dim PCDPartPrograms As Object
  Dim PCDPartProgram As Object
  Dim PCDCommands As Object
  Dim PCDCommand As Object
  Dim PCDComment As Object

  Dim sContents As String
  Dim iCnt As Integer
  Dim j, k, n As Integer
  Dim iCount As Integer
  Dim num As Integer

  Dim sArrayErsatz, S, S2 As String
  Dim retVal

  Set PCDApp = CreateObject("PCDLRN.Application")
  Set PCDPartPrograms = PCDApp.PartPrograms
  Set PCDPartProgram = PCDApp.ActivePartProgram
  Set PCDCommands = PCDPartProgram.Commands

  sArrayErsatz = ""
  For iCnt = 1 To PCDCommands.count
    Set PCDCommand = PCDCommands.Item(iCnt)
    If (PCDCommand.IsComment) Then
      Set PCDComment = PCDCommand.CommentCommand
      If (PCDComment.CommentType = 1) And (InStr(1, PCDComment.Comment, "Aln") < 1) Then
        For j = 1 To 10
          If (PCDComment.GetLine(j) = "") Then Exit For
          
          sContents = PCDComment.GetLine(j)
          'MsgBox sContents 'Bulle mit Klammern
          sContents = Replace(sContents, "(", "")
          sContents = Replace(sContents, ")", "")
          'MsgBox sContents 'Bulle ohne Klammern
          
          If IsNumeric(sContents) Then
            num = CInt(sContents)
            k = InStr(1, sArrayErsatz, CStr(num) + ".")
            If k = 0 Then
              S = "1"
              sArrayErsatz = sArrayErsatz + CStr(num) + ".1;"
            End If
            If k > 0 Then
              n = InStr(k, sArrayErsatz, ";")
              S2 = Mid(sArrayErsatz, k, n - k + 1)
              k = InStr(k, sArrayErsatz, ".")
              S = Mid(sArrayErsatz, k + 1, n - k - 1)
              If IsNumeric(S) Then S = CStr(CInt(S) + 1)
              sArrayErsatz = Replace(sArrayErsatz, S2, CStr(num) + "." + S + ";")
            End If
            sContents = "(" & CStr(num) + "." + S & ")"
            'MsgBox sContents 'Angepasste Bulle mit Klammern
            retVal = PCDComment.SetLine(j, sContents)
          End If
        Next
      End If
    End If
  Next iCnt​
Reply
  • good Day,

    the pcDMIS basic.dll / compiler is a bit wonky.
    I 've had bad experiences with arrays, and I would recommend that you avoid them altogether in pcDMIS scripts
    auto convert combined with arrays rarely works, prefer to use Cint Cstr etc

    well,

    a bit exaggerated but here a string is used as an array substitute: 
      Dim PCDApp As Object
  Dim PCDPartPrograms As Object
  Dim PCDPartProgram As Object
  Dim PCDCommands As Object
  Dim PCDCommand As Object
  Dim PCDComment As Object

  Dim sContents As String
  Dim iCnt As Integer
  Dim j, k, n As Integer
  Dim iCount As Integer
  Dim num As Integer

  Dim sArrayErsatz, S, S2 As String
  Dim retVal

  Set PCDApp = CreateObject("PCDLRN.Application")
  Set PCDPartPrograms = PCDApp.PartPrograms
  Set PCDPartProgram = PCDApp.ActivePartProgram
  Set PCDCommands = PCDPartProgram.Commands

  sArrayErsatz = ""
  For iCnt = 1 To PCDCommands.count
    Set PCDCommand = PCDCommands.Item(iCnt)
    If (PCDCommand.IsComment) Then
      Set PCDComment = PCDCommand.CommentCommand
      If (PCDComment.CommentType = 1) And (InStr(1, PCDComment.Comment, "Aln") < 1) Then
        For j = 1 To 10
          If (PCDComment.GetLine(j) = "") Then Exit For
          
          sContents = PCDComment.GetLine(j)
          'MsgBox sContents 'Bulle mit Klammern
          sContents = Replace(sContents, "(", "")
          sContents = Replace(sContents, ")", "")
          'MsgBox sContents 'Bulle ohne Klammern
          
          If IsNumeric(sContents) Then
            num = CInt(sContents)
            k = InStr(1, sArrayErsatz, CStr(num) + ".")
            If k = 0 Then
              S = "1"
              sArrayErsatz = sArrayErsatz + CStr(num) + ".1;"
            End If
            If k > 0 Then
              n = InStr(k, sArrayErsatz, ";")
              S2 = Mid(sArrayErsatz, k, n - k + 1)
              k = InStr(k, sArrayErsatz, ".")
              S = Mid(sArrayErsatz, k + 1, n - k - 1)
              If IsNumeric(S) Then S = CStr(CInt(S) + 1)
              sArrayErsatz = Replace(sArrayErsatz, S2, CStr(num) + "." + S + ";")
            End If
            sContents = "(" & CStr(num) + "." + S & ")"
            'MsgBox sContents 'Angepasste Bulle mit Klammern
            retVal = PCDComment.SetLine(j, sContents)
          End If
        Next
      End If
    End If
  Next iCnt​
Children
© 2024 Hexagon AB and/or its subsidiaries. Privacy Policy | Cloud Services Agreement