Script Help - Object Variable Not Set

I have written a short script to check if a probe/tip used in the program requires calibration. I am not the most fluent with scripting but I have posted below what I have. Once a program is opened and executed for the first time I usually receive the error 'Object Variable not set' (I indicated in the code which line). If I open the code in the script editor and run it after the initial error it works fine. I can close and reopen the program and still only sometimes I get the error. I believe I am doing something wrong by trying to set an object to a variable or in the initializing/releasing of it but have tried everything I can think of. Can anyone spot what I did wrong?

Dim App As Object
Dim Part As Object
Dim Cmds As Object
Dim Cmd As Object
Dim PartProbes As Object
Dim PartProbe As Object
Dim ProbeTips As Object
Dim ProbeTip As Object

''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
Sub Main()
        OpenPCDMIS    'Initialize PC-DMIS
        CheckCal
        ClosePCDMIS    'Release PC-DMIS Objects
End Sub
''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''

Sub CheckCal()    'Calculate Program Run Time

    Dim CalNeeded$
    CalNeeded = 0
    For Each Cmd In Cmds
        If Cmd.IsLoadProbe Then strProbe = Cmd.GetText(FILE_NAME, 0)       'Grab LoadProbe filename
        If Cmd.IsActiveTip Then        'Grab tip data For previously loaded probe
            strTip = Cmd.ID
            Set PartProbes = Part.Probes
            PartProbes.Visible = False
            Set PartProbe = PartProbes(strProbe)
            Set ProbeTips = PartProbe.Tips
            Set ProbeTip = ProbeTips(strTip)

            T2 = ProbeTip.Date                '** Runtime Error - Object Variable Not Set **

            CalDate = ((Month(T2) - 1) * DaysPerMo) + Day(T2)
            NowDate = ((Month(Now) - 1) * DaysPerMo) + Day(Now)
            NowDate = NowDate + ((Year(Now) - Year(T2)) * 365)       'Correct For year differences

               'check If calibrated In last 7 days
            If (NowDate - CalDate) >= 7 Or (NowDate - CalDate) < 0 Then
                CalNeeded = 1
                Set NeedsCal = Part.GetVariableValue("NEEDCAL")
                NeedsCal.StringValue = CalNeeded
                Part.SetVariableValue "NEEDCAL", NeedsCal
                Exit Sub        'Exit once Any tip is found To need calibration
            End If
        End If
    Next Cmd
End Sub




'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
Sub OpenPCDMIS()  'Connect And Populate Appplication Objects
        Set App = CreateObject("PCDLRN.Application.7.1") ' 7.1 is specific To v2012 MR1
        Set Part = App.ActivePartProgram
        Set Cmds = Part.Commands
End Sub

Sub ClosePCDMIS()  'Destroy Appplication Objects
    On Error Resume Next
        Set App = Nothing
        Set Part = Nothing
        Set Cmds = Nothing
    On Error GoTo 0
End Sub

mkopesky_ over 8 years ago

This is working really well for me (using v2017 R1) so just a couple shots in the dark to spark some discussion.

Are the probe objects not being cleaned up causing the ProbeUtilitiesWindow to return null on second run?
Perhaps a dummy UNLOAD probe with no tip is causing the null object?
Cancel
Vote Up 0 Vote Down

Sign in to reply

Cancel
ToneLoke over 8 years ago

There are no dummy probes or anything and there is always a load probe before an active tip command . When you say probe objects cleaned up, should I be setting the objects = nothing before reinitializing them?
Cancel
Vote Up 0 Vote Down

Sign in to reply

Cancel
RandomJerk over 7 years ago

Do you need a PUBLIC declaration in your DIM statements? That will let them have project scope. Could be wrong, it's been a while.
Cancel
Vote Up 0 Vote Down

Sign in to reply

Cancel

ToneLoke over 7 years ago

I made a few changes and no longer am seeing any errors. All I did was initialize the probe object once a probe was found and the tip object once a tip was found rather than trying to initialize both probe and tip together. Logically I don't really understand the difference but it's working for me so far. Thanks for the help.

CalNeeded = 0
strProbe = ""
For Each Cmd In Cmds
    If Cmd.IsLoadProbe And strProbe <> Cmd.GetText(FILE_NAME, 0) Then
        strProbe = Cmd.GetText(FILE_NAME, 0) 'Grab LoadProbe filename
        Set PartProbes = Part.Probes
        PartProbes.Visible = False
        Set PartProbe = PartProbes.Item(strProbe)
    End If
    If Cmd.IsActiveTip Then 'Grab tip data For loaded probe
        Set ProbeTips = PartProbe.Tips
        Set ProbeTip = ProbeTips.Item(Cmd.ID)

        T2 = ProbeTip.Date

        CalDate = ((Month(T2) - 1) * DaysPerMo) + Day(T2)
        NowDate = ((Month(Now) - 1) * DaysPerMo) + Day(Now)
        NowDate = NowDate + ((Year(Now) - Year(T2)) * 365) 'Correct For year differences

        If (NowDate - CalDate) >= 7 Or (NowDate - CalDate) < 0 Then 'check If calibrated In last 7 days
            CalNeeded = 1
            Set NeedsCal = Part.GetVariableValue("NEEDCAL")
            NeedsCal.StringValue = CalNeeded
            Part.SetVariableValue "NEEDCAL", NeedsCal
            Exit Sub 'Exit once Any tip is found To need calibration
        End If
    End If
Next Cmd